Fix #263 - Update the npm package metadata #264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cosinekitty
reviewed
Nov 8, 2022
| "url": "https://github.com/cosinekitty/astronomy/issues" | ||
| "files": [ | ||
| "esm/astronomy.js", | ||
| "astronomy.d.ts", |
There was a problem hiding this comment.
@matheo (I'm asking this because I don't know much about npm packages.) Should we also include astronomy.ts in this list? Do people ever develop against TypeScript source directly within an npm package?
There was a problem hiding this comment.
nope, ESM is already close to the ts syntax
and npmJS is not supposed to have TS packages 😅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reorganized the fields to leave the file pointers at the end,
adding the
exportsas suggested in the Skypack docs:https://docs.skypack.dev/package-authors/package-checks